Skip to content

Fix parse_query decoding multiple plus signs #921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lpil merged 1 commit into from
May 14, 2026
Merged

Fix parse_query decoding multiple plus signs #921

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/gleam_stdlib.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,7 +482,7 @@ function unsafe_percent_decode(string) {
}

function unsafe_percent_decode_query(string) {
return decodeURIComponent((string || "").replace("+", " "));
return decodeURIComponent((string || "").replaceAll("+", " "));
}

export function percent_decode(string) {
Expand Down
5 changes: 5 additions & 0 deletions test/gleam/uri_test.gleam
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -517,6 +517,11 @@ pub fn parse_query_string_basic_test() {
assert parsed == [#("weebl bob", "1"), #("city", "örebro")]
}

pub fn parse_query_string_multiple_spaces_test() {
let assert Ok(parsed) = uri.parse_query("one+two+three=four+five+six")
assert parsed == [#("one two three", "four five six")]
}

pub fn parse_query_string_duplicates_test() {
// Duplicates keys not overridden
let assert Ok(parsed) = uri.parse_query("a[]=1&a[]=2")
Expand Down
Loading