custom equals/hashCode for dictionary nodes.#929
Merged
Conversation
yoshi-monster
force-pushed
the
dict_collision_equality
branch
from
c3a51d1 to
24816cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #928
this makes dictionary Nodes a real class, such that I can override
equalsandhashCodein a more idiomatic manner.For overflow nodes, the order of items in the final arrays was not guaranteed, so in that program of the issue, structural comparison did not work anymore.
Fun side-effect of all of that that maybe makes adding another 100 lines to the dict implementation worth it is that equality is now 10 times faster, I guess. I tried a bunch of things trying to compress all the tree walking methods but I couldn't come up with anything good -.-
anyways, ~ 💜