Update release step of GitHub workflow to use gh CLI#36
Merged
Conversation
Also set workflow permissions
chris-allan
approved these changes
Nov 19, 2025
Member
chris-allan
left a comment
chris-allan
left a comment
There was a problem hiding this comment.
Looks good to me. We obviously can't really test until we make an actual release but I'm happy for this to go in if you are, @sbesson? We can mop up any idiosyncrasies when we do the next release.
Member
Author
|
Agreed that testing these is usually painful. I have created a rc tag on my fork based off this commit which seems to achieve what we need - https://github.com/sbesson/omero-ms-thumbnail/releases/tag/v0.6.1-rc1 |
Member
|
Looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by the work in ome/ome-common-java#107, this makes use of the
ghCLI available in the GitHub runners with the defaultGITHUB_TOKENand the appropriate permissions to create a GitHub release including generated notes and assets instead of a third-party action