Mhd shearing box - #8
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an MHD shearing-wave regression test (Balbus & Hawley 2006) and updates the shearing-box implementation to support it, including adjustments to the shearing-wave test configurations, documentation, and CI coverage.
Changes:
- Add a new
shearing_wave_mhdtest (Python driver + validation + input file) and run it in CI (serial + MPI). - Update linear-shear remapping to apply a 2/3 de-aliasing mask during remaps.
- Update existing shearing-wave test parameters (resolution/CFL), expand InitFlow documentation, and clean up test outputs.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/shearing_wave/validate.py | Relaxes success threshold for the hydro shearing-wave validation. |
| test/shearing_wave/astra.ini | Updates hydro shearing-wave grid resolution and CFL. |
| test/shearing_wave_mhd/validate.py | New MHD shearing-wave validation against an ODE reference solution. |
| test/shearing_wave_mhd/shearing_wave_test.py | New Python init/output hooks for capturing shearing-wave MHD mode amplitudes. |
| test/shearing_wave_mhd/astra.ini | New MHD shearing-wave test configuration (mean field + shearing box parameters). |
| test/shearing_wave_compressible/astra.ini | Updates compressible shearing-wave grid resolution and output configuration. |
| src/shear/linearshear.hpp | Adds de-aliasing masking during remap (but currently breaks MPI indexing; see PR comment). |
| src/rightHandSide/mhd.hpp | Updates MHD RHS behavior/source terms to support the new test scenario. |
| src/rightHandSide/hydro.hpp | Removes a verbose remap log line in hydro RHS post-stage. |
| doc/source/input_file.rst | Documents mean_field InitFlow entry and clarifies mean_flow wording. |
| .github/workflows/astra-ci-jobs.yml | Adds MHD + compressible shearing-wave test runs to CI (serial + MPI). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add the MHD shearing wave test from Balbus & Hawley (2006)
fix the source terms in the mhd rhs.