Skip to content

Sod iso test for compressible hydro - #9

Merged
glesur merged 8 commits into
masterfrom
sod-iso
Jun 24, 2026
Merged

Sod iso test for compressible hydro#9
glesur merged 8 commits into
masterfrom
sod-iso

Conversation

@glesur

@glesur glesur commented Jun 24, 2026

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds an isothermal Sod shock-tube regression test for the compressible_hydro RHS, and introduces new physics knobs (eta_rho, rho_floor) to support stable compressible runs and validation in CI.

Changes:

  • Add a new test/sod-iso test (init script, INI config, and validation against an analytic Sod solution) and wire it into GitHub Actions (serial + MPI).
  • Extend CompressibleHydro with optional density diffusion (eta_rho) and a density floor used to avoid division-by-zero in the real-space nonlinear “windup”.
  • Update input-file documentation to describe the new compressible_hydro parameters, and adjust Python embedding signal handling.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
test/sod-iso/validate.py New validator comparing simulation output against analytic Sod solution (found a brittle slicing bug).
test/sod-iso/sod_test.py New Python init condition for the Sod isothermal setup.
test/sod-iso/astra.ini New runtime configuration for the Sod isothermal compressible hydro test.
src/rightHandSide/compressible_hydro.hpp Adds eta_rho diffusion in ImplicitStep and uses rho_floor during real-space nonlinear term construction.
src/astrapy.cpp Restores default SIGINT handling after initializing the embedded Python interpreter.
pytools/sod.py Adds an analytic Sod solver (but currently uses exit() on invalid inputs).
doc/source/input_file.rst Documents eta_rho and rho_floor (one formula needs correction to reference rho, not v).
.github/workflows/astra-ci-jobs.yml Runs the new sod-iso test in Serial and Parallel CI jobs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread test/sod-iso/validate.py
Comment thread pytools/sod.py
Comment thread pytools/sod.py
Comment thread doc/source/input_file.rst
Comment thread src/rightHandSide/compressible_hydro.hpp Outdated
glesur and others added 2 commits June 24, 2026 17:48
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@glesur
glesur merged commit 20435c9 into master Jun 24, 2026
5 checks passed
@glesur
glesur deleted the sod-iso branch June 24, 2026 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants