Repository navigation
fix(details): keep metadata icons with their labels - #345
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Metadata icons could be left at the end of a line while their labels wrapped below. Use non-breaking spaces in the shared metadata line to keep icons with their labels and separators with the preceding part.
Verified by reproducing the orphaned genre icon on Interstellar in the iPhone 17 Pro simulator, then observing it wrap with Adventure after the fix. Correctness, complexity, and UI reviews found no actionable issues. All 1,555 tests, lint, typecheck, and git diff --check passed.
This JS-only change hot reloads. Android, web, and enlarged accessibility text were not checked. Existing Reanimated/Worklets warnings were present in the shared runtime log.