Repository navigation
perf(episode): render before the seasons list resolves - #347
Merged
Merged
Conversation
Owner
Author
|
Review findings from GPT-6, posted on behalf of Gian.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Episode details waited for the complete seasons catalogue even after the opened episode was ready. Render that episode first, defer its neighbors, and track the settled episode by identity as the catalogue arrives.
On Android, remount the pager when the catalogue becomes available so Fabric applies the expanded content and selected offset together. iOS keeps the page mounted. The existing Android solution documents the layout constraint.
Validation: delegated correctness and complexity reviews, UI review, 1,557 passing tests, lint, type checking, whitespace checks, and all 12 external URL probes. Live iPhone simulator checks exercised a single-page-to-816-episode expansion at S10E4, Next to E5, and a swipe back to E4, with no captured console warnings.
Android runtime QA could not complete because the emulator runtime stopped answering CDP; restart recovery was aborted. Android's one-time pager remount can reset vertical reading position, expanded content, and accessibility focus when seasons arrive; preserving those transient states is deferred. Web and release-device QA and latency measurements were not run. Source-only changes hot reload and require no native rebuild.