Skip to content

fix(log): resolve later anime cours before provider fan-out - #348

Merged
glpecile merged 1 commit into
mainfrom
fix/anime-canonical-cour
Oct 28, 2026
Merged

glpecile merged 1 commit into
mainfrom
fix/anime-canonical-cour

Conversation

@glpecile

Copy link
Copy Markdown
Owner

Logging a later anime season from a TMDB or Trakt show could miss AniList and send Simkl a write against the first cour. Resolve the matching AniList cour through related entries and ani.zip before fan-out, retaining canonical episode numbers for Trakt and Serializd. Simkl skips with a reason when the cour or its MAL identity cannot be established.

Validated with 1,560 passing tests, lint, typecheck, and diff checks. The success regression fails against the old planner; both safety regressions fail without the skip guard. Live public AniList and ani.zip reads confirm Cyberpunk S2 maps to AniList 195539 / MAL 61990 and entry-relative episode 3.

Correctness and ponytail complexity reviews completed. No device UI or authenticated provider writes were tested. JS changes hot reload; no native rebuild is needed. Layout-aware reverse mapping for other tracker season structures remains a follow-up.

@github-actions github-actions Bot added the fix Included in release notes as a Fix label Oct 28, 2026
@glpecile

Copy link
Copy Markdown
Owner Author

Review findings from GPT-6, posted on behalf of Gian.

Correctness review found that an unresolved later cour still allowed Simkl to receive a first-cour show identity. Fixed the planner to produce a reasoned skip, including when a resolved cour lacks a MAL id. Added owner-boundary coverage proving Simkl delivery never runs for either miss; both tests fail without the guard. The updated correctness review approved, and the independent ponytail complexity review found no issues.

The final change resolves related AniList cours through matching ani.zip TVDB identity and episode mappings, shares the existing reverse mapper, and keeps Trakt/Serializd canonical episode numbers. All 1,560 tests, lint, typecheck, and diff checks pass. Live public provider reads confirm the Cyberpunk S2 identity and S2E3 → entry 3 mapping. No authenticated provider writes or device UI were tested. Layout-aware reverse mapping for other tracker season structures remains a follow-up. These JS changes hot reload without a native rebuild.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
shinobu 24988fd Oct 28 2026, 04:06 AM

@glpecile
glpecile merged commit 566c079 into main Oct 28, 2026
4 checks passed
@glpecile
glpecile deleted the fix/anime-canonical-cour branch October 28, 2026 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Included in release notes as a Fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant