Add strict checks to zip calls#144
Merged
Merged
Conversation
Carifio24
added
the
no-changelog-entry-needed
Member
Author
|
The test failure seems to be related to |
Carifio24
force-pushed
the
strict-zip-checks
branch
from
d65f49b to
df0c929
Compare
Member
Author
|
Rebased to pick up fixes to the test (which are unrelated to this PR) that are on main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds two explicit
strict=Trueparameters tozipcalls. In both cases it will always be true that the two iterables will be of equal length - one is from items directly constructed in a test, and in the other case both iterables are constructed from linspaces of the same size.For a description of why we want this, see here.