Repository navigation
Conversation
…ter enum CI workflows were building ddm from linuxdeepin/ddm master, which lacks the DaemonMessages::ShowGreeter enum added by ddm PR linuxdeepin#106. This caused a compilation error in greeterproxy.cpp when building treeland PR linuxdeepin#1305. - deepin workflow: clone ddm from glyvut/ddm (PR linuxdeepin#106 head) instead of linuxdeepin/ddm master - archlinux workflow: replace pacman ddm install with building ddm from glyvut/ddm source, installing build deps (extra-cmake-modules, pam, libxau) instead
Owner
|
滚 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI Fix: Build DDM from PR linuxdeepin#106 source
Root Cause
src/greeter/greeterproxy.cpp:518referencesDDM::DaemonMessages::ShowGreeter, which is only defined in ddm PR #106 (not yet merged). The CI workflows build ddm fromlinuxdeepin/ddmmaster, which lacks this enum value, causing:Fix
Updated both CI workflows to build ddm from the PR linuxdeepin#106 source (which contains
ShowGreeter):treeland-deepin-build.yml: Clone ddm fromglyvut/ddm(PR feat: add distro logo and hide some buttons linuxdeepin/treeland#106 head) instead oflinuxdeepin/ddmmastertreeland-archlinux-build.yml: Replacepacman -S ddmwith building ddm fromglyvut/ddmsource + installing build depsNote
This is a temporary CI fix. Once ddm PR linuxdeepin#106 is merged to
linuxdeepin/ddmmaster, these workflow changes should be reverted to uselinuxdeepin/ddmmaster again. The merge order should be: ddm PR linuxdeepin#106 first, then treeland PR linuxdeepin#1305.This branch is based on
glyvut/treeland:greet(PR linuxdeepin#1305 head) with only the CI workflow fix added. Merge this PR to apply the fix to PR linuxdeepin#1305's branch.