Repository navigation
fix(window-transition): apply code review fixes - #8
Merged
Merged
Conversation
Remove unnecessary #include <QtCore> and fix QML opacity binding to prevent first-frame flicker on close animations. 移除不必要的 #include <QtCore>，修复 QML opacity 绑定以防止 关闭动画首帧闪烁。 Log: 应用代码审查修复，移除宽泛头文件并修复 opacity 绑定 Issue: Fixes linuxdeepin#1394 Influence: 移除 surfacewrapper.cpp 中过于宽泛的 QtCore 头文件引用， WindowTransition.qml 中 BufferItem 的 opacity 改为直接绑定， 避免关闭动画时首帧闪烁。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply 2 code review fixes from WM-480 review:
#include <QtCore>fromsurfacewrapper.cpp(already hasQTimerandQVariant)WindowTransition.qml: replaceopacity: 0+Component.onCompletedwith direct bindingopacity: root.direction === 1 ? 1 : 0Merging this PR will update the
feat/animation-newbranch and automatically update linuxdeepin#1394.WM-480