Open
Conversation
added 5 commits
August 15, 2021 17:09
…s for the corrections
…iling with the old one
…iling with the old one
…atplotlib dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Output raw files from ngspice sometimes have a form that means variables are not detected correctly by the regular expressions. Like in this example:
"Variables:
0 v-sweep voltage
1 voltage
2 @include[current] capacitance
3 i(@m.xm1.msky130_fd_pr__nfet_01v8_lvt[ib]) current dims=0
...
"
In this case, lines 1 and 2 were merged. Ultimately, this leads to a mismatch between the number of fields in the dtype and the number of fields in the array of values, so the file cannot be read. Have changed from a regular expression to a line by line interpretation to get round this. Also, as in the contribution guidelines, have added some tests for this code. Tests are based on a simulation of the open source skywater library.