Fix widget text invisible when desktop dimming enabled - #17
Merged
Merged
Conversation
Removes the rollbar-apple SPM dependency, RollbarNotifier import and setup in AppDelegate, Info.plist token, pbxproj package references, Package.resolved pin, CI/CD ROLLBAR_ACCESS_TOKEN injection, and the release workflow steps for dSYM upload and deploy notification. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
macOS desktop widgets render in vibrant mode. When "Dim widgets on desktop" is enabled, the system applies an additional alpha multiplier. Hierarchical styles like .secondary/.tertiary already have reduced opacity in vibrant mode, so after the dimming multiplier they fall to near-zero contrast and become invisible — only shapes and SF Symbols remain visible. Add a widgetForeground helper that substitutes .primary with explicit opacity values in vibrant mode, keeping text readable in both dimmed and un-dimmed states while preserving the original hierarchical styles in full-color mode (sidebar/Notification Center). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (10)
💤 Files with no reviewable changes (4)
📝 WalkthroughWalkthroughRemoves Rollbar error tracking integration from the project across CI workflows, project configuration, and application code. Additionally, updates widget views with environment-aware foreground styling to improve visual consistency across different widget rendering modes. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.foregroundStyle(.secondary)and lower hierarchical styles below the visibility threshold in vibrant rendering modewidgetForegroundhelper that uses.primarywith explicit opacity in vibrant mode, preserving original styles in full-color mode (sidebar)Test plan
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com
Summary by CodeRabbit
Chores
Style