Skip to content

security: reject placeholder values in secrets at startup #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gnacho merged 1 commit into from
Aug 30, 2026
Merged

security: reject placeholder values in secrets at startup #123

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions internal/config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import (
"os"
"path/filepath"
"strconv"
"strings"
"time"
)

Expand Down Expand Up @@ -105,6 +106,21 @@ func Load() *Config {
if cfg.Demo {
cfg.Mock = true // demo implica colectores mock
}
// Placeholder detection (30-Ago-2026, leccion Yuvomi)
placeholderMarkers := []string{"cambia", "changeme", "change-me", "example", "placeholder", "your-secret", "replace_me", "xxx"}
for _, kv := range []struct{ key, val string }{
{"ADMIN_PASSWORD", cfg.AdminPassword},
{"WEBHOOK_SECRET", cfg.WebhookSecret},
{"SMTP_PASS", cfg.SMTPPass},
} {
low := strings.ToLower(kv.val)
for _, m := range placeholderMarkers {
if kv.val != "" && strings.Contains(low, m) {
log.Fatalf("config: %s contiene un valor de ejemplo del .env.example; genera un secreto real", kv.key)
}
}
}

secret := os.Getenv("SESSION_SECRET")
if secret == "" {
b := make([]byte, 32)
Expand Down
Loading