feat(pools): import an existing pool from the web UI - #139
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The import operation already existed in the backend (
POST /api/pools/import), but the web UI only listed importable pools as plain text and never imported anything. ThePoolsbutton calledimportPool()with no name, and the missing-pools banner only navigated toPools. After a power loss where a pool fails to auto-import, there was no self-service way to bring it back up from the UI.Changes
ImportPoolModal: lists importable pools (zpool import), lets the admin select one, requires typing the pool name to confirm, imports it (zpool import <name>), then refreshes and toasts.Pools"Import existing pool" button to the modal (previously it only printed the list and never imported).HttpProvider.importPool(name): the backend answers 202 with no body, so readingr.importablethrew on an undefined response.No backend change is needed:
PoolImportList/PoolImportand the endpoint were already in place.Verification
go test ./internal/...green.npm run buildOK.POST /api/pools/importresponds{"importable":[]}(HTTP 200) with an admin session.Closes #138