fix(heal): resolve the real package arch after sysupgrade - #302
Merged
Merged
Conversation
…#296) opkg print-architecture lists pseudo-archs (all, noarch) first, so the heal picked 'noarch' and found no matching ipk; take the arch from the installed busybox package instead and skip the pseudo-archs. Also replace the wildcard-to-regex sed (which broke on '/' inside the character class) with direct grep patterns.
gnacho
added a commit
that referenced
this pull request
Sep 22, 2026
…#296) (#302) opkg print-architecture lists pseudo-archs (all, noarch) first, so the heal picked 'noarch' and found no matching ipk; take the arch from the installed busybox package instead and skip the pseudo-archs. Also replace the wildcard-to-regex sed (which broke on '/' inside the character class) with direct grep patterns. Co-authored-by: gnacho <hnacho@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #301 (issue #296).
Verified end-to-end on a real opkg router: factory 24.10.5 image flashed with keep settings, netgrip files survived via sysupgrade.conf, the registry entry was gone, and the heal restored
netgrip 0.72.2-1from the latest release on its own. Two bugs surfaced in that run and are fixed here:opkg print-architecturelists pseudo-archs (all,noarch) first, so the heal resolved the arch asnoarchand found no matching ipk. The arch now comes from the installedbusyboxpackage, with the filtered print-architecture as fallback.sedfor asset matching broke on the/inside the character class ("bad option in substitution expression"); the asset URL match is now a direct grep pattern per flavor.