Repository navigation
fix(clients): deleted clients stay deleted; fleet MACs purged; sane IPs - #1290
Merged
Merged
Conversation
#1278, three related fixes. (1) Deleting a client now writes a tombstone (new deleted_clients table): any source that still reports the MAC online (a cached AP station entry, a collector) no longer re-admits it, and it disappears from the ghost list too. Re-adding the MAC through the allowlist clears the tombstone. (2) The base MAC of every fleet unit (routers.mac plus each agent's bridge MAC) is purged from the registry on every cycle - the units' own management addresses were learned as clients through the switches' FDB and lingered offline forever. (3) Device IPs that are not parseable IPs (some sources report a dash-formatted MAC hostname in the ip field) are dropped at ingestion and on display.
This was referenced Oct 8, 2026
gnacho
added a commit
that referenced
this pull request
Oct 13, 2026
…) (#1397) The only client-join alert was 'unknown device', which fires only for nameless clients after a few poll ticks (#234). A device that resolves a hostname on the first tick (DHCP reservation, static name) was never unknown, so a named-but-new client joined silently - no log, no push. - noteDevicesSeen now returns the first-timers (MACs inserted into device_seen for the first time) that already carry a name; nameless ones stay with unknown-device so a new client never alerts twice. - Startup anti-avalanche: when the table was empty on entry (first boot or fresh DB), the whole online set is seeded silently; later additions alert normally. - trackNewClients emits a clients-category info alert, urgent so it also pushes, one-shot per MAC persisted in kv (new_client_alerted:) with the same semantics as unknown_alerted (#248). A MAC that already alerted as unknown does not re-alert here when it later gains a name, and tombstoned clients (#1278/#1290) never re-alert. - Carries name/mac/ip/router/attachment; i18n es/en. Tests: named first-timer alerts once with full vars, nameless stays with unknown-device, empty-table seeding is silent but later joins alert, unknown-alerted guard. Closes #1323
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1278: (1) client deletes write a tombstone so cached sources stop resurrecting them; (2) fleet units' own MACs are purged from the client registry every cycle; (3) non-IP values in the ip field are dropped. Tombstones clear on re-admission via the allowlist.