Repository navigation
fix(fleet): deleting a router removes its agent stub and revokes the token - #1291
Merged
Merged
Conversation
…token #1276: deleting a router only removed the config row - the persisted agent state (agent.state.*), the transport record and the agent registry entry survived, so the unit kept appearing in Devices/Agents with no way to remove it. Deleting now revokes the agent token (a still installed agent gets 401 and stops re-creating the entry), forgets the registry entry, purges the persisted state and drops the learned bridge MAC from the client registry. Re-adding the router requires re-pairing the agent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1276: the agent's persisted state, transport record and registry entry survived a router deletion, leaving an unremovable stub in Devices/Agents. Deletion now revokes the token, forgets the entry and purges the state and the learned client MAC.