Repository navigation
fix(clients): tombstones filter the final device list, not just the registry - #1295
Merged
Merged
Conversation
…egistry #1292: the reporter was right that the delete pipeline was broken beyond the registry - the two stale iPhone entries had NO device_seen row at all (no first_seen/last_seen), so they were being re-emitted fresh every cycle by a live source (a stale wireless station entry on the AP), never "re-admitted" through the registry. filterTombstoned now runs on both final device lists (overview and router detail), dropping tombstoned MACs no matter which source emits them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1292: the stale entries had no device_seen row - they were re-emitted every cycle by a live source (stale AP station), which the registry-level tombstone never saw. The final device lists now drop tombstoned MACs regardless of the emitting source.