fix(agent): self-heal stale watchdog cron entry after sysupgrade (#879) - #880
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A sysupgrade wipes /usr/sbin but keeps /etc, so routers that had the old watchdog cron entry are left with a line pointing at a deleted file: cron logs a missing-command error every 2 minutes until something removes it. The package defaults and the console reinstall clean it, but neither runs on a plain sysupgrade.
The agent init script now self-heals at start: if the watchdog binary is gone and a netpulse-watchdog cron entry is still there, the entry is removed. Applied to all init copies (standalone deploy file, the install-agent.sh embedded copy, the server reinstall script and the OpenWrt package init). Verified functionally in sh: entry removed when the binary is missing, kept when present, clean no-op when there is no entry.
Closes #879