The version consistency test repository_version_manifest_is_valid_and_matches_the_crate (src/core/updates.rs) only checks that version.json agrees with CARGO_PKG_VERSION. Since the AppStream metainfo file now ships a <release version="..." date="..."/> entry (added in #159), that entry is an unverified second source of truth: a bump can land in Cargo.toml/version.json/PKGBUILD while the metainfo release entry stays stale, and nothing fails.
Proposal: extend the same test to read data/io.github.gnacho.nextsync.metainfo.xml and assert it contains a <release version="${CARGO_PKG_VERSION}" .../> tag, so a forgotten metainfo bump fails CI.
Acceptance criteria:
- The consistency test fails (red) when the metainfo release entry does not match the crate version.
- The test passes (green) when they agree.
- No new external dependencies; the check parses the file text.
The version consistency test
repository_version_manifest_is_valid_and_matches_the_crate(src/core/updates.rs) only checks thatversion.jsonagrees withCARGO_PKG_VERSION. Since the AppStream metainfo file now ships a<release version="..." date="..."/>entry (added in #159), that entry is an unverified second source of truth: a bump can land in Cargo.toml/version.json/PKGBUILD while the metainfo release entry stays stale, and nothing fails.Proposal: extend the same test to read
data/io.github.gnacho.nextsync.metainfo.xmland assert it contains a<release version="${CARGO_PKG_VERSION}" .../>tag, so a forgotten metainfo bump fails CI.Acceptance criteria: