fix(credentials): find and adopt Python-era keyring entries; resolve push by account id - #12
Merged
Merged
Conversation
…push by account id
Python nextsync stored secrets with {server, username} attributes under
schema io.github.gnacho.nextsync.Account; the Rust store only searched
the account_id key, so migrated accounts had no credentials: empty
remote-folder picker, syncs unable to authenticate. get_for_account now
falls back to the legacy attributes and adopts the secret under
account_id (legacy item left in place). The notify_push configure path
also resolved the keyring with the login name instead of the account id
and could never authenticate, even for wizard-created accounts.
Closes #11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11