Conversation
connect_progress() wires the progress forwarder after start() has already fired startup syncs. The run_active flag introduced in #145 starts false, so every event from the in-flight startup run was dropped and the folder row showed no per-file progress or bar movement. Seed the flag from scheduler.is_running() when connecting, so an in-flight run keeps emitting events. Later runs are still gated by prepare_sync()/finished() as before. Closes #148
GTK may not repaint the row when properties are updated from a subscription callback, so after a sync finishes the row could still show "Synchronizing…" with the old file caption until the user clicked elsewhere to force a redraw. Queue an explicit draw on the whole slot after every state render and on the progress label after every progress change, so the icon, spinner, run bar, subtitle and caption all update together without user interaction. Closes #150
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #148, closes #150
fix(progress): seed run_active flag when connecting during a run
connect_progress() wires the progress forwarder after start() has already fired startup syncs. The run_active flag introduced in #145 starts false, so every event from the in-flight startup run was dropped and the folder row showed no per-file progress or bar movement.
Seed the flag from scheduler.is_running() when connecting, so an in-flight run keeps emitting events. Later runs are still gated by prepare_sync()/finished() as before.
fix(ui): force folder row redraw after state/progress updates
GTK may not repaint the row when properties are updated from a subscription callback, so after a sync finishes the row could still show "Synchronizing…" with the old file caption until the user clicked elsewhere to force a redraw.
Queue an explicit draw on the whole slot after every state render and on the progress label after every progress change.