fix(ui): explain why a folder waits and align the summary state - #167
Merged
Merged
Conversation
A folder row queued behind the shared permit showed only the generic 'Waiting to synchronize' label, hiding why it was stuck (the scheduler does attach a specific reason like 'Waiting for another account to finish'). Surface that message on the row (issue #165). A run that ends with conflicted copies also re-queued the local feedback, bouncing a folder with unresolved conflicts (a large tree reconciling tens of thousands of files) into a sync loop while smaller folders waited. On a conflicted run, drop the local feedback and leave the message that the user must review the log, letting only the cadence of interval/remote triggers retry. Tests for both, gate 663 passed + 1 ignored. Closes #165
The queued message said 'another account' and was generic (issue #165 follow-up). Name the folder that holds the shared permit instead, so the row reads 'Waiting for <folder> to finish…' (falls back to 'another folder'). The account summary card could read 'Connected' next to a red light: the connection text only distinguished Offline while the light used a severity map. Align the text with the severity so problem states (error, credentials rejected, keyring locked, delete review) say what the light conveys. Also use the same severity mapping for the initial icon render so it does not flip between globes and status icons. w/ #165
The deletion-guard strings translated 'deletions' as 'eliminaciones', but the flow is about reviewing a mass local deletion. Use 'borrados masivos' across the guard strings for clearer Spanish (Review deletions, approve once, none pending).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #165 and the follow-up feedback.
Problem
Changes
Tests
Gate: 664 passed + 1 ignored, clippy/fmt clean.