Repository navigation
fix: coherent waiting message and self-healing keyring retry - #171
Merged
Merged
Conversation
When several folders are queued behind the shared permit, every row repeated the same 'Waiting for <folder> to finish…' (and could name a folder that was already synced). Only the head of the queue should name the folder it waits on; the rest use the generic 'Waiting for another folder to finish…'. The permit exposes waiter_count; a scheduler with no waiters ahead is the head and names the holder, others stay generic. Closes #169
This reverts commit 7149f04.
After login the Secret Service can be momentarily unavailable, so the first run reports a keyring-locked outcome and arms the keyring_locked flag. That flag only cleared on the next external trigger, which may never arrive in the session, so the account stayed 'keyring locked' until the app restarted. On a keyring-locked outcome, schedule a capped exponential backoff retry that re-enters the engine and re-reads the credentials; once the service is ready the run succeeds and the flag clears on its own. The retry budget is capped so a genuinely locked collection parks in the keyring-locked state instead of retrying forever. Tested: keyring_locked_schedules_its_own_retry, keyring_retry_budget_is_capped. Closes #170
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #169 and #170.
#169 — coherent waiting message
When several folders are queued behind the shared permit, every row repeated the same 'Waiting for to finish…' (and could name a folder that was already synced). Now only the head of the queue names the folder it waits on; the rest use the generic 'Waiting for another folder to finish…'. The permit exposes waiter_count to know who is the head.
#170 — keyring stuck until restart
After login the Secret Service can be momentarily unavailable, so the first run reports a keyring-locked outcome and arms the flag. That flag only cleared on the next external trigger, which could never arrive, so the account stayed locked until the app restarted. Now a transiently locked keyring schedules a capped exponential backoff retry that re-reads the credentials and clears the flag once the service is ready. The budget is capped so a genuinely locked collection parks in the keyring-locked state instead of retrying forever.
Tests
Gate: 667 passed + 1 ignored, clippy/fmt clean.