test(login_flow): make the local-server integration test deterministic - #176
Merged
Merged
Conversation
The test server did two sequential recv() assuming the initiate request landed before the poll. The client (ureq) can reuse a keep-alive connection and tiny_http serves multi-threaded, so the request order is not guaranteed and the poll occasionally got the wrong slot -> PollHttp 400 (flaky ~1/143). Answer each request by its URL (initiate vs /poll) so the test no longer depends on request order or connection reuse. Verified 300/300 passes (was ~1/143 before). Closes #174
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #174.
The test server did two sequential recv() assuming the initiate landed before the poll. ureq can reuse a keep-alive connection and tiny_http serves multi-threaded, so request order is not guaranteed and the poll occasionally hit the wrong slot producing PollHttp 400 (flaky ~1/143).
Now the server answers each request by URL (initiate vs /poll), independent of order or connection reuse.
Verified 300/300 passes (was ~1/143 before).