feat(credentials): cache account passwords in memory - #180
Merged
Merged
Conversation
One Secret Service session negotiation per account per process instead of one per credential lookup (the pattern desktop clients like Iotas use): every get_for_account used to open a fresh DH session, and a sync run did several. The cache is written through on set, evicted on delete, and invalidated when a run ends in AuthFailed so the next lookup re-reads the keyring after the user signs in again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #178
What
One Secret Service session negotiation per account per process instead of one per credential lookup (the pattern desktop clients like Iotas use):
get_for_accountserves an in-memory cache first; keyring resolutions populate itsetwrites through,deleteevictsAuthFailedinvalidates the cached password, so the next lookup re-reads the keyring after the user signs in againBefore: up to 3
SecretService::connect(Dh)per lookup x every folder x every few minutes.Tests
cache_serves_until_invalidated,set_writes_through_and_delete_evicts,auth_failed_outcome_invalidates_the_cached_password