Group the mass-deletion review by top-level folder (#182) - #192
Merged
Merged
Conversation
…182) The review dialog listed up to 100 individual missing paths in a flat list. For a large cleanup (removed SDK, virtualenv, build caches) that wall of paths is unreadable in a small window. Missing paths are now grouped by their first path component: one expandable row per directory with its file count (folder icon, count subtitle), expanded children capped, and small groups plus loose files listed individually. Rows are sorted by group size. The grouping lives in a pure, unit-tested function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #182.
Problem
The delete-guard review dialog lists up to 100 individual missing paths in a flat list. For a large cleanup (removing a vendored SDK, virtualenvs or build caches - thousands of files across a handful of directories) the flat list is overwhelming: the user cannot tell at a glance what is about to be deleted, which is exactly the decision the dialog exists to support.
Change
Group the missing paths by their first path component (top-level directory relative to the folder root) and show one row per group:
Files
src/core/delete_guard.rs(+156): group/aggregate the missing paths.src/ui/main_window.rs: render the grouped rows with expanders.po/es.po+src/util/translations/es.rs: new i18n entries.Gate: clippy clean, fmt applied, tests green.