docs: keep store env example in sync - #219
Soumoditya wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe store environment example documents the supported native backend and adds an opt-in flag for public-domain exposure. The changes do not alter runtime behavior. ChangesStore environment examples
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This updates store environment-variable documentation without changing runtime behavior. The example settings and review-requested documentation details are in place, with no current merge-readiness risk identified. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Description checkExplanation The description explains the purpose and lists the intended changes, but it omits the required Test plan section and the checklist confirmations from the repository template. It also contains a malformed path reference to apps/store/.env.example. Resolution Add a Test plan section that states which validation was run or why no test was needed. Complete the required checklist items, including sign-off and relevant apps/store validation. Correct the malformed apps/store/.env.example path reference. Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
0e5210d to
5dffad7
Compare
|
Thanks for this one — the two genuinely-missing vars (
Fix 1 and 2 and I'll merge it. |
Signed-off-by: Soumoditya <soumodityapramanik@gmail.com>
Signed-off-by: Soumoditya <soumodityapramanik@gmail.com>
5dffad7 to
b52fe3e
Compare
|
Addressed the requested changes: the clone directory stays commented, the ZeroEntropy key is included, and the documentation retains the source-read wording. |
Summary\n\nKeep �pps/store/.env.example aligned with the documented runtime variables.\n\n## Changes\n\n- Add STORE_BACKEND and the public-domain guard to the example.\n- Provide the persistent clone-directory setting as a deployable example.\n- Remove the documentation note that the example omits runtime variables.\n\nCloses #192
Summary by CodeRabbit