Skip to content

Update: update readme.md - #205

Merged
vcaesar merged 1 commit into
masterfrom
dev-v1
Mar 24, 2026
Merged

Update: update readme.md#205
vcaesar merged 1 commit into
masterfrom
dev-v1

Conversation

@vcaesar

@vcaesar vcaesar commented Mar 24, 2026

Copy link
Copy Markdown
Member

Please provide Issues links to:

  • Issues: #

Provide test code:

Description

...

Copilot AI review requested due to automatic review settings March 24, 2026 15:34
@vcaesar vcaesar added the update label Mar 24, 2026
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@vcaesar
vcaesar merged commit 6224258 into master Mar 24, 2026
8 of 10 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates project metadata by adjusting the module’s declared Go version and cleaning up README badges.

Changes:

  • Bump go.mod go directive from 1.17 to 1.25.
  • Remove a legacy (commented-out) Travis CI badge from README.md.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
go.mod Raises the module’s minimum declared Go toolchain version.
README.md Removes an obsolete commented badge entry.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread go.mod
module github.com/go-ego/gse

go 1.17
go 1.25

Copilot AI Mar 24, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumping the go directive from 1.17 to 1.25 is a breaking compatibility change for downstream users (older Go toolchains will refuse to build this module). If the project is intentionally dropping support for older Go versions, please also update the README (it currently says "Go 1.11+") and any other published compatibility statements to match the new minimum.

Suggested change
go 1.25
go 1.17

Copilot uses AI. Check for mistakes.
Comment thread go.mod
module github.com/go-ego/gse

go 1.17
go 1.25

Copilot AI Mar 24, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title/description indicate a README update, but this change also updates the module's minimum Go version. Please reflect the Go version bump in the PR description (and ideally link the motivating issue/decision) so reviewers and release notes capture the breaking change.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants