Skip to content

Add FTP Server Test Container#2

Merged
umputun merged 2 commits intomasterfrom
add-ftp-container
Apr 10, 2025
Merged

Add FTP Server Test Container#2
umputun merged 2 commits intomasterfrom
add-ftp-container

Conversation

@umputun
Copy link
Copy Markdown
Member

@umputun umputun commented Apr 9, 2025

Summary

  • Add \ implementation for testing FTP operations in integration tests
  • Implement methods for uploading, downloading, and listing files on the container
  • Support recursive directory creation and proper path handling
  • Add secure file operations with path validation
  • Update README with comprehensive documentation and usage examples

Implementation Details

  • Uses \ Docker image
  • Provides a similar interface to other test containers in the package
  • Implements passive mode connectivity for reliable file transfers
  • Includes proper error handling and resource cleanup
  • Comprehensive test suite verifying all operations

@umputun
Add FTP container implementation for testing FTP operations
2d746f5 
- Add FTPTestContainer for testing FTP file transfers
- Implement methods for uploading, downloading, and listing files
- Add comprehensive path handling for directories
- Add secure file operations with path validation
- Update README with documentation and examples
@umputun umputun requested a review from Copilot April 9, 2025 23:58
Copilot AI reviewed Apr 9, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • go.mod: Language not supported

@umputun
Update containers/ftp.go
b5291aa 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@umputun umputun merged commit 6ab8926 into master Apr 10, 2025
3 checks passed
@umputun umputun deleted the add-ftp-container branch April 10, 2025 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@umputun