feat: add the ability to complete tasks directly from the widget. #168
Conversation
…d a circular dependency bug with background refresh
kolaente
changed the title
android/app/src/main/kotlin/io/vikunja/flutteringvikunja/widget/AppWidget.kt
Outdated
Show resolved
Hide resolved
android/app/src/main/kotlin/io/vikunja/flutteringvikunja/widget/AppWidget.kt
Outdated
Show resolved
Hide resolved
|
@leschbenedikt @kolaente The above check is failing because now dart is saying that it wants to format 157 files? I dont think we want to touch so many files on this mr. |
|
@brokoli18 it said only one was changed: |
android/app/src/main/kotlin/io/vikunja/flutteringvikunja/widget/AppWidget.kt
Outdated
Show resolved
Hide resolved
android/app/src/main/kotlin/io/vikunja/flutteringvikunja/widget/AppWidget.kt
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| @Composable | ||
| private fun GlanceContent(context: Context, currentState: HomeWidgetGlanceState) { |
There was a problem hiding this comment.
The size and position of the widget changes depending of the number of task.
I think this should always be the same.
There was a problem hiding this comment.
Can you elaborate on what you mean here. When the widget is first created its a 4x1 Rectangle. After the user resizes it it should stay the same size regardless of how many tasks there are.
| Text("Today:") | ||
| } | ||
| items(todayTasks.sortedBy { it.dueDate }) { task -> | ||
| RenderRow(context, task, prefs, "HH:mm") |
There was a problem hiding this comment.
The pattern shouldn't be hardcoded, the should depend on the locale.
You can just pick some of the predefined ones from flutter
There was a problem hiding this comment.
I have looked at the possible solutions here, but using something like DateTimeFormatter.ISO_LOCAL_DATE_TIME the date is either too big for the widget, or doesn't display the right components. In short the string fomatter is just much more flexible, is there an issue with me using it here?
| Text("OverDue") | ||
| } | ||
| items(otherTasks.sortedBy { it.dueDate }) { task -> | ||
| RenderRow(context, task, prefs, "dd MMM HH:mm") |
|
@leschbenedikt I made some changes/comments, can you have a look when you have a moment |
3 participants
Also fixed a circular dependency bug with background refresh.
Resolves #152