cmd/compile: emit LLVM source locations for Go PCLN - #117
Merged
Conversation
zhouguangyuan0718
added a commit
that referenced
this pull request
Aug 10, 2026
Pin GoALLC CI to the published LLVM 23.1.0 v8 payload at revision 445acfc09213ef8f70906a10f32ba96c1d0813c7. Promote the runtime tests whose backend and GC visibility fixes are included in the payload/current main: - abi/method_wrapper.go (LLVM #59) - fixedbugs/issue78081.go (LLVM #60) - stackobj2.go (Go #115) All three pass the local Darwin/arm64 LLVM `default<O2>` -> GoObj -> link -> runtime path. PR CI qualifies the released Linux amd64/arm64 artifacts. The v8 ARM64 layout places the morestack call before the indirect body call. Update the structured AArch64 frame check to derive exact PCDATA ranges from call offsets while retaining the strict map association checks: morestack uses map 0 and the indirect call uses map 1. `devirtualization_nil_panics.go` was also evaluated for promotion. Its nil panic and recover behavior works, but it fails the required source-line assertion (`llvm-ir:1`, want line 28). Keep it explicitly gray until the pending Go #117 and LLVM #62 PCLN changes are merged and released; the test itself is not weakened. Validation: - v8 release contains Linux amd64/arm64 archives and SHA256 assets - JSON/Python parsing and `git diff --check` - `TestLLVMTestPolicy` PASS - focused LLVM O2 runtime tests for method_wrapper, issue78081, stackobj2 PASS - full standalone plugin CTest with objview: 64/64 PASS - `devirtualization_nil_panics.go` reproduces only the known pcline gap
zhouguangyuan0718
force-pushed
the
codex/pcln-debug-info
branch
from
August 11, 2026 05:30
e8c2d2c to
747360b
Compare
zhouguangyuan0718
force-pushed
the
codex/pcln-debug-info
branch
from
August 12, 2026 00:50
9ebdc28 to
85fe97b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scope
This PR only feeds pcfile, pcline, and pcinline generation. It intentionally does not generate Go target-object DWARF carriers, type DIEs, variables, dbg.declare records, or variable locations. Target-object DWARF is a separate follow-up.
Generic LLVM DWARF emission is not changed. GoObj-specific collection and inline anchoring stay in the Go handlers and plugin.
LLVM payload
Validation