cmd/compile: encode LLVM ABI0 in function names - #130
Merged
Conversation
Keep ABIInternal LLVM names unchanged and append the reserved <ABI0> suffix to every ABI0 declaration and definition. Remove goobj.symbol.name metadata now that the LLVM GoObj writer derives ABI identity from names.
zhouguangyuan0718
force-pushed
the
codex/abi0-name-contract
branch
from
August 13, 2026 09:58
7d2f7d8 to
cd433d8
Compare
zhouguangyuan0718
force-pushed
the
codex/abi0-name-contract
branch
from
August 13, 2026 16:09
0c50e68 to
2a34094
Compare
zhouguangyuan0718
force-pushed
the
codex/abi0-name-contract
branch
from
August 13, 2026 16:16
def4d14 to
207442d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the reserved
<ABI0>suffix as the only LLVM storage-nameidentity for ABI0 Go functions. ABIInternal function names remain
unchanged.
Remove
goobj.symbol.namemetadata emission from function, data, anddebug-info paths. Keep the LLVM calling convention as the lowering
contract while allowing GoObj to derive symbol ABI solely from the
function name.
Reject logical Go symbol names that already use the reserved suffix,
and update the cgo unsafe-argument codegen checks.
Update the pinned GoALLC LLVM payload to
goallc-llvm23.1.0-20260813T171727Zat1d142acb4dab7262347b57ac341235913b210f40. Refresh the affectedplugin fixtures and ABI tests for native-Go small-leaf stack-check
elision and the
PCDATA_StackMapIndex=-1entry sentinel. No runtimefrontend support is included here.
Tested locally against the final LLVM source and plugin: