cmd/compile: use typed goret for stack ABI results - #139
Open
zhouguangyuan0718 wants to merge 7 commits into
Open
cmd/compile: use typed goret for stack ABI results#139zhouguangyuan0718 wants to merge 7 commits into
zhouguangyuan0718 wants to merge 7 commits into
Conversation
zhouguangyuan0718
force-pushed
the
codex/llvm-goret-go-verify
branch
from
August 20, 2026 10:50
793695c to
af536c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
goretpointer parameter with"goretindex"="N"SelectN,SelectNAddr, direct calls, indirect/closure calls, and tail-return adaptationThis change intentionally establishes the result ABI first. Caller result homes are still ordinary entry allocas; forwarding or otherwise eliding those homes is a separate optimization and is not required for correctness.
Validation
cmd/compile/internal/ssa: passarchive/tarpasses with-gcflags=all=-enablellvm\ -llvmironlyanddefault<O2>;TestReadTruncationalso passes for 10 consecutive runsJoint linux-amd64/linux-arm64 CI selects the immutable payload produced from the exact LLVM PR head below.
LLVM-PR: goallc/llvm-project#88
Additional standard-library qualification after LLVM GoObj relocated-private-constant support:
-gcflags=all=-enablellvm\ -llvmironlyflag per test invocation; dependency enumeration and per-package flag expansion were removed after direct all-LLVM flate and runtime entry tests passed