cmd/compile: preserve file-backed data in LLVM IR - #140
Merged
zhouguangyuan0718 merged 1 commit intoAug 18, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Large embedded files are represented by an LSym with FileInfo and a nil P slice. The native Go object writer streams FileInfo.Name, but LLVM data lowering previously allocated Size bytes and copied only P, producing a zero initializer. This made encoding/json/jsontext FuzzCoder consume a zeroed embedded corpus.
Materialize file-backed data once in the LLVM data lowerer and share the cached bytes between type construction and initializer construction. Validate the FileInfo size against the LSym, reject the invalid inline/file combination, and check both short and long reads. Native object emission and Go semantics are unchanged.
Add focused compiler tests for raw IR contents and malformed lengths, plus a >1 KiB string and []byte go:embed test that exercises LLVM O2 GoObj emission, linking, execution, writable storage, and separation from the read-only string.
Validation on darwin/arm64:
Linux qualification remains on the revision-locked release selected by CI.