cmd/llvmplugin: update merged test expectations - #44
Closed
zhouguangyuan0718 wants to merge 2 commits into
Closed
Conversation
Author
|
Superseded by #43: both the X86 indirect-call offset expectation and the pointer-vector fixture alignment fix are already present on go1.27.master. Rebuilt the latest toolchain and confirmed the complete plugin CTest suite passes 48/48, so there is no remaining unique diff to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Production-semantics evidence
go tool objdumpshows the x86 register- and memory-indirectCALLinstructions at function offset 17, each carrying exactly[0:0]R_CALLIND. Their stack-growth calls remain directR_CALL:runtime.morestack_noctxtrelocations. The direct-call fixture has noR_CALLIND.The pointer-vector fixture's previous
<2 x ptr>, align 16exceeded the GoObj x86 stack alignment and correctly reached the realigned-allocation diagnostic first. A<1 x ptr>, align 8fixture has no independent alignment violation and reaches the intended unsupported pointer-vector diagnostic. Pointer-vector support is not expanded.Validation
ctest --test-dir pkg/goallc-llvmplugin --output-on-failure(48/48)opt -passes=verifyfor both affected inputsllc -verify-machineinstrsfor x86_64 and AArch64 GoObj indirect-call codegengit diff --check