cmd/compile: add first-phase defer lowering for LLVM - #74
Merged
Conversation
Author
LLVM blacklist probe (darwin/arm64)Using the matching LLVM payload and
I did not bulk-promote these cases into |
Author
|
Whitelist refresh is now scoped to this PR: 71 Darwin/arm64 codegen files and 1068 runtime files. The defer probe added 113 stable runtime cases. I removed llvm_alloca_statepoint_gc.go and llvm_newproc_gc.go from this layer because neither failure is fixed by defer lowering itself; #75 requalifies the alloca case after its scoped-root fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement first-phase classic defer support in the LLVM backend.
Summary:
Whitelist on Darwin/arm64:
The inherited llvm_alloca_statepoint_gc.go and llvm_newproc_gc.go cases are intentionally excluded here. The former is requalified by the scoped stack-object-root fix in #75; the latter remains a known runtime failure.
Dependencies:
Validated with upstream defer/recover/range tests and focused LLVM/GoObj checks.