cmd/compile: preserve guarded AMD64 FP intrinsics in LLVM - #96
Open
zhouguangyuan0718 wants to merge 1 commit into
Open
cmd/compile: preserve guarded AMD64 FP intrinsics in LLVM#96zhouguangyuan0718 wants to merge 1 commit into
zhouguangyuan0718 wants to merge 1 commit into
Conversation
zhouguangyuan0718
force-pushed
the
codex/goobj-guarded-fp-intrinsics
branch
from
August 6, 2026 16:17
11b903b to
fddbceb
Compare
zhouguangyuan0718
force-pushed
the
codex/goobj-guarded-fp-intrinsics
branch
from
August 6, 2026 17:30
fddbceb to
55f4541
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On AMD64, Go SSA guards SSE4.1 rounding and FMA operations with runtime.x86HasSSE41 and runtime.x86HasFMA. Lowering their true branches to generic LLVM intrinsics loses that contract at the target boundary: baseline X86 codegen may emit external trunc/floor/ceil/roundeven/fma symbols.
Use the guarded X86 intrinsics added by goallc/llvm-project#48 for AMD64 while keeping the generic LLVM intrinsics on other architectures. Update LLVM codegen expectations accordingly.
Validation:
Depends on goallc/llvm-project#48. The two runtime cases remain graylisted until linux/amd64 CI can execute them. This PR is intentionally left unmerged for review.