GoObj: preserve pcsp across disconnected emitted blocks - #66
GoObj: preserve pcsp across disconnected emitted blocks#66zhouguangyuan0718 wants to merge 1 commit into
Conversation
|
Hello @zhouguangyuan0718 👋 Thank you for submitting a Pull Request (PR) to the LLVM Project. Since this is your first PR, here are a few useful links covering our main contribution policies and review practices.
Please reply to this message to confirm that you have read these policies, especially the LLVM AI Tool Use Policy, and that any AI tool usage has been noted in the PR description. Frequently asked questionsHow do I add reviewers? This PR will be automatically labeled, and the relevant teams will be notified. For some parts of the project, reviewers may also be added automatically. You can also add reviewers manually using the Reviewers section on this page. If you cannot use that section, it is probably because you do not have write permissions for the repository. In that case, you can request a review by tagging reviewers in a comment using What if there are no comments? If you have not received any comments on your PR after a week, you can request a review by pinging the PR with a comment such as “Ping”. The common courtesy ping rate is once a week. Please remember that you are asking for volunteer time from other developers. Are any special GitHub settings required to contribute to LLVM? We only require contributors to have a public email address associated with their GitHub commits, see this section of LLVM Developer Policy for details. If you have questions, feel free to leave a comment on this PR, or ask on LLVM Discord or LLVM Discourse. Thank you, |
Summary
Late target passes may remove the last CFG predecessor of a machine basic block while retaining that block in the physical emission order. The GoObj pcsp calculation previously required every emitted block to be reachable from the function entry CFG and failed even though the block still occupies a real PC interval.
This change:
No Go frontend logic, package/function special case, or invented metadata is involved.
Validation
Two unrelated goobj-pcsp-cfg.ll expectation drifts reproduce on the unmodified v8 payload and are intentionally not included.