X86: Repair Go ABI state at ABI0 boundaries - #76
Conversation
|
Hello @zhouguangyuan0718 👋 Thank you for submitting a Pull Request (PR) to the LLVM Project. Since this is your first PR, here are a few useful links covering our main contribution policies and review practices.
Please reply to this message to confirm that you have read these policies, especially the LLVM AI Tool Use Policy, and that any AI tool usage has been noted in the PR description. Frequently asked questionsHow do I add reviewers? This PR will be automatically labeled, and the relevant teams will be notified. For some parts of the project, reviewers may also be added automatically. You can also add reviewers manually using the Reviewers section on this page. If you cannot use that section, it is probably because you do not have write permissions for the repository. In that case, you can request a review by tagging reviewers in a comment using What if there are no comments? If you have not received any comments on your PR after a week, you can request a review by pinging the PR with a comment such as “Ping”. The common courtesy ping rate is once a week. Please remember that you are asking for volunteer time from other developers. Are any special GitHub settings required to contribute to LLVM? We only require contributors to have a public email address associated with their GitHub commits, see this section of LLVM Developer Policy for details. If you have questions, feel free to leave a comment on this PR, or ask on LLVM Discord or LLVM Discourse. Thank you, |
9743f08 to
c859054
Compare
e7e02f7 to
9c3341c
Compare
a0fbb6d to
f6436d9
Compare
9c3341c to
9a95a71
Compare
f6436d9 to
c2800d8
Compare
9a95a71 to
c7d9623
Compare
c7d9623 to
e544ba5
Compare
## Summary - use `go-nosplit` as the sole opt-out from the native Go stack check; split functions call `runtime.morestack*<ABI0>` with an ordinary target call - emit one function-level `EntryArgsStackMapID` record for every GoObj Go function, independent of split/nosplit behavior - serialize the entry map as map 0 and use the Machine-CFG-derived PCSP stream to restore map 0 on entry-stack-depth paths, without identifying `runtime.morestack*` in GoObj emission - serialize ordinary statepoints as additional live maps and let same-PC statepoints override a CFG map-0 transition - retain complete ABI register homes for morestack retries while omitting unused, potentially poison incoming pointer values from the entry GC bitmap - model `go-systemstack` with `g.stackguard1` and `runtime.morestackc` ## Stack position This is 2/3 in the runtime LLVM support stack. Depends on #77. Next/final layer: #76, X86 ABI0/ABIInternal boundary repair. #75 has been folded into this PR so the stack semantics and the entry-map contract can be reviewed as one coherent change. ## Testing - fresh Release build of `llc` for X86 and AArch64 - 12 `GoObjStackMapUtilsTest` unit tests - 38 Generic/X86/AArch64 GoObj codegen tests - dedicated object test covering map 0 -> ordinary map 1 -> CFG-derived map 0 on both targets
e544ba5 to
faa99ab
Compare
faa99ab to
82ff580
Compare
This follows up the runtime stack-growth support merged through #73. The PR intentionally keeps the work in two reviewable commits: 1. Elide morestack for final-frame small leaf functions on AArch64 and X86, while keeping the entry ArgsPointerMaps STACKMAP independent. X86 also matches native Go's leaf-like handling of the zero-argument panic helpers, including the extra 8-byte CALL return-PC limit. The LLVM frontend consumes generic SSA, so it does not emit Go DUFFCOPY/DUFFZERO calls; inline memory intrinsics remain call-free instead. 2. Restore native Go's PCDATA_StackMapIndex entry sentinel of -1. ArgsPointerMaps/LocalsPointerMaps pair 0 is still serialized; runtime getStackMap normalizes -1 to bitmap 0. CFG ranges that return to entry SP depth also return to -1. This removes the artificial 32-byte AArch64 stack-growth prefix from zero-frame leaf functions without removing their entry argument maps. The GoALLC LLVM CI test list now includes the leaf-policy, entry-sentinel, and entry-CFG fixtures so the payload jobs exercise these contracts directly. Validation: - Focused leaf/stack-check and sentinel suite: 8/8 passed. - Broader Generic/X86/AArch64 GoObj and Go CodeGen suite: 52/52 passed; go-memset-inline was excluded because its stale REP expectation already fails on the #76 baseline llc. - git clang-format --diff reports no changes.
Summary
<ABI0>symbol suffix; statepoints use their existing calling-convention operandgogo, and write-barrier thunks use their dedicated ABIInternal clobber contractDesign
R14 and XMM15 are fixed reserved registers rather than ordinary caller-saved or callee-saved allocation resources. The transition repair therefore does not participate in SelectionDAG lowering and does not require a target pseudo or a distinct ABI0 register mask.
The
x86-go-abipre-emit pass scans finalized MachineInstr calls. For an ordinary Go call,<ABI0>is the only ABI0 identity. It insertsXORPS XMM15, XMM15and a TLS reload of R14 before ABI0-to-ABIInternal calls or after ABIInternal-to-ABI0 calls.Calls inserted late without the ordinary Go call mask are intentionally ignored. This matches native Go behavior for split-stack morestack calls and write-barrier thunks.
Stack position
This is the X86 ABI-boundary layer on top of merged #73 and merged #77.
#71 remains the temporary cross-repository integration and payload PR until this PR is merged.
Testing
llcandFileCheckx86-go-abi; repair appears only after the late pass