Stabilize render diagnostics timing tests on Windows#226
Closed
paganotoni with Copilot wants to merge 4 commits into
Closed
Stabilize render diagnostics timing tests on Windows#226paganotoni with Copilot wants to merge 4 commits into
paganotoni with Copilot wants to merge 4 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job go1.25/windows-latest
Stabilize render diagnostics timing tests on Windows
Jul 23, 2026
Member
|
@Mido-sys I took copilot for a run on this one and it seems to have fixed the tests. Does this make sense? I did not update your PR because I cannot. Im expecting to close this PR once you confirm it makes sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
go1.25/windows-latestActions job was failing on diagnostics tests that assumed extremely short renders would always produce non-zero durations. On Windows, those paths can legitimately measure as0s, so the suite was asserting on timer resolution rather than behavior.Root cause
EngineDuration, helper duration, or partial duration were strictly greater than zero.Test stabilization
Scope