Skip to content

Fix status code for duplicate job and datasets#257

Closed
thuibr wants to merge 2 commits into
goccy:mainfrom
thuibr:main
Closed

Fix status code for duplicate job and datasets#257
thuibr wants to merge 2 commits into
goccy:mainfrom
thuibr:main

Conversation

@thuibr

@thuibr thuibr commented Dec 13, 2023

Copy link
Copy Markdown

No description provided.

@thuibr

thuibr commented Dec 13, 2023

Copy link
Copy Markdown
Author

@goccy this is to replace #184. I tried to address your comments, but I don't think I can use errResponse. I'm copying what's done for duplicate tables instead.

@thuibr thuibr marked this pull request as draft December 13, 2023 23:11
@thuibr

thuibr commented Dec 13, 2023

Copy link
Copy Markdown
Author

For some reason, even after making ErrDuplicatedDataset, it's still being reported as an internalError, and this equality check is returning false:

https://github.com/goccy/bigquery-emulator/pull/257/files#diff-4dacc7a06791d88085bc744a0a2aa16559cb5b9b8fddd705177bfa2fbfe41d29R683

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant