fix: prevent database rebuild when server starting#269
Open
bjmmartin wants to merge 1 commit into
Open
Conversation
|
Hey there @totem3 , have you seen this maybe? Is there a timeline estimate for this fix, if any? Thanks im advance! |
|
Hi @goccy , this one seems pretty useful to stay parked, do you agree? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While using the emulator, we encounter the same error as #207.
After looking a bit at the code, I found that when the server is starting, we try to reinsert all data, that are already in the database.
The proposal here is to rebuild the project only when the
--data-from-yamlis provided.So if we found a project, and we are just loading from the database, we stop here, but if we load with the option it removes the project and its jobs and dataset, and rebuild it from scratch.
I don't know all cases, so it might break some edge case, maybe it could be an option to the command.
Let me know if some changes are required. And thanks a lot for the project 🙏