fix(server): Support google.protobuf.Timestamp values for the storage write API#416
Open
coxley wants to merge 6 commits into
Open
fix(server): Support google.protobuf.Timestamp values for the storage write API#416coxley wants to merge 6 commits into
coxley wants to merge 6 commits into
Conversation
Author
|
I assume @goccy is the best maintainer to review? Thanks in advanced! |
adw-okamu
added a commit
to adw-okamu/bigquery-emulator
that referenced
this pull request
Feb 18, 2026
Remove RECORD column handling for nested timestamps as it depends on go-zetasqlite#232 which is not yet merged. The core google.protobuf.Timestamp support for the storage write API is retained. Co-Authored-By: Claude <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
While BigQuery recommends to send
TIMESTAMPcolumns encoded asint64, they also supportgoogle.protobuf.Timestamp: https://cloud.google.com/bigquery/docs/supported-data-types. This is critical for workloads that ingest JSON data, where RFC3339 strings can naturally decode into atimestamppb.Timestamp.The client SDK making this easier with the following issue and PR:
Testing these changes work against Google, but panic the emulator:
This PR ensures that
google.protobuf.Timestampmessages are converted totime.Timeearly indecodeRowData.It also fixes a bug for
RECORDcolumns containingTIMESTAMPcells — but it depends on goccy/go-zetasqlite#232 to make the test pass.Test Plan
Added a new test case that reproduces the problem, and is fixed with these changes: