Normalize StructSource table data before loading#485
Open
oshiro3 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
I have created a patch to resolve Issue #483; please review it.
Please comment if you have any concerns regarding the fix or the tests.
This pull request fixes intermittent field misalignment that occurs when reading
REPEATED RECORDdata viaStructSource.In the previous
StructSource, table data was passed directly toAddTableData, which meant that nested RECORD values backed by maps could be inserted without being normalized based on the table schema. Because the iteration order of Go maps is non-deterministic, iterated STRUCT fields werestored in an unpredictable order, causing subsequent
UNNESTfield accesses (e.g.,item.skip) to read values from different fields.This fix normalizes the table data using
types.NewTableWithSchemawithin theaddProjectread path before insertion.Testing
We added an internal server test that directly calls
addProjectwith aREPEATED RECORDcolumn to verify thatUNNEST(items)returns fields in the expected schema order.go test ./server -run TestAddProjectNormalizesRepeatedRecordData -count=1