New auth flow#430
Open
chinmay29fynd wants to merge 10 commits intomasterfrom
Open
Conversation
vivek-gofynd
requested changes
May 6, 2026
| }); | ||
| return response.data || {}; | ||
| } catch (error) { | ||
| return { auth_mode: 'legacy' }; |
Collaborator
There was a problem hiding this comment.
On each error it will be switched to legacy, don't we need to handle based on response ?
There was a problem hiding this comment.
@vivek-gofynd will do this instead?
client-config will fall back to legacy only when the endpoint returns 404.
| const tokenRes = await ApiClient.post(`${authBase}/oauth/token`, { | ||
| headers: { | ||
| 'Content-Type': 'application/json', | ||
| 'x-fp-cli': `${packageJSON.version}`, |
Collaborator
There was a problem hiding this comment.
@chinmay29fynd Check if this can be handled at axios interceptor level
vivek-gofynd
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New auth flow