feat(text): keep MultiFace font fallback on GPU - #513
Open
besmpl wants to merge 3 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Source-aware GPU font fallback (#451)
MultiFacenow exposes its fallback chain and contiguous source-font runs, and shaping retains the owning face on everyShapedGlyph. The glyph-mask and MSDF GPU paths rasterize those runs into ordered batches instead of returning a nil-source error; shaped CPU fallback also resolves each glyph's source. Mixed-font tests cover deterministic run offsets, source identity, glyph-mask batching, and MSDF batching.Fixes #521.
Verification:
go test ./...,go test -tags nogpu ./...,go vet ./....