fix(app): preserve stroke fringe in dirty redraws - #230
Open
kivutar wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Framework-managed incremental redraw used the exact dirty widget bounds as its clip. Widget painters commonly center strokes on those bounds, so the clip removed the outer part of the stroke and its antialiasing fringe. This made button and text-field borders disappear during incremental hover or focus updates, especially at fractional scale.
The fix retains incremental rendering and adds only a one-logical-pixel margin around the existing dirty union; it does not force a full redraw.
Validation