Skip to content

tests: Added unit tests for user create command #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rkcoder101 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

tests: Added unit tests for user create command #688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5e22b0d
test/refactored user create cmd and wrote unit tests for the same
rkcoder101 Feb 7, 2026
5cd70fb
fix/added a testcase suggested by copilot in review
rkcoder101 Feb 7, 2026
d895b59
refactor: changed the test design in order to avoid the usage of inte…
rkcoder101 Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 25 additions & 30 deletions cmd/harbor/root/user/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,27 @@ import (
"github.com/spf13/cobra"
)

var fillUser = create.CreateUserView

func CreateUser(opts *create.CreateView, createUserAPI func(opts create.CreateView) error) {
var err error

if opts.Email == "" || opts.Realname == "" || opts.Password == "" || opts.Username == "" {
fillUser(opts)
}

err = createUserAPI(*opts)

if err != nil {
if isUnauthorizedError(err) {
log.WithFields(log.Fields{
"action": "user create",
}).Error("Permission denied: The current account does not have the required permissions to create users.")
Copy link

Copilot AI Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The unauthorized/permission-denied message here differs from other user commands (most log/return "Permission denied: Admin privileges are required to execute this command."). This inconsistency can be confusing for users and makes it harder to match errors across commands/tests. Consider standardizing the message (and logging style) across the user subcommands.

Suggested change
}).Error("Permission denied: The current account does not have the required permissions to create users.")
}).Error("Permission denied: Admin privileges are required to execute this command.")

Copilot uses AI. Check for mistakes.
} else {
log.Errorf("failed to create user: %v", err)
}
}
}
func UserCreateCmd() *cobra.Command {
var opts create.CreateView

Expand All @@ -31,30 +52,7 @@ func UserCreateCmd() *cobra.Command {
Short: "create user",
Args: cobra.ExactArgs(0),
Run: func(cmd *cobra.Command, args []string) {
var err error
createView := &create.CreateView{
Email: opts.Email,
Realname: opts.Realname,
Comment: opts.Comment,
Password: opts.Password,
Username: opts.Username,
}

if opts.Email != "" && opts.Realname != "" && opts.Password != "" && opts.Username != "" {
err = api.CreateUser(opts)
} else {
err = createUserView(createView)
}

// Check if the error is due to unauthorized access.

if err != nil {
if isUnauthorizedError(err) {
log.Error("Permission denied: Admin privileges are required to execute this command.")
} else {
log.Errorf("failed to create user: %v", err)
}
}
CreateUser(&opts, api.CreateUser)
},
}

Expand All @@ -67,12 +65,9 @@ func UserCreateCmd() *cobra.Command {

return cmd
}

func createUserView(createView *create.CreateView) error {
create.CreateUserView(createView)
return api.CreateUser(*createView)
}

func isUnauthorizedError(err error) bool {
if err == nil {
return false
}
return strings.Contains(err.Error(), "403")
}
Loading
Loading